broker: prevent overlap of policy evaluations #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a policy is sent for evaluation by a handler, it is placed into the eval broker queue. If the queue already has an eval for the policy, it discards one of them, keeping the most recent one. This is used to guarantee that a policy is never processed in parallel by different workers. The code had the `return` statement in the wrong scope, causing a duplicate eval to be enqueued even when the policy was already been processed, resulting in unexpected concurrent policy evaluations.
Closed
jrasell
approved these changes
Jan 2, 2024
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Ah yeah, good point. Expanded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a policy is sent for evaluation by a handler, it is placed into the eval broker queue. If the queue already has an eval for the policy, it discards one of them, keeping the most recent one. This is used to guarantee that a policy is never processed in parallel by different workers.
The code had the
returnstatement in the wrong scope, causing a duplicate eval to be enqueued even when the policy was already been processed, resulting in unexpected concurrent policy evaluations.Closes #610