Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha: add support for specifying the lock namespace #832

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 17, 2024

When HA mode is enabled, the leader lock must be managed in a specific namespace, but when setting the nomad.namespace configuration to the wildcard * value the Nomad API client was trying to write to this namespace value, which is not allowed.

This commit adds a new high_availability.lock_namespace configuration to allow operators to specify the exact lock variable namespace.

Closes #828.

When HA mode is enabled, the leader lock must be managed in a specific
namespace, but when setting the `nomad.namespace` configuration to the
wildcard `*` value the Nomad API client was trying to write to this
namespace value, which is not allowed.

This commit adds a new `high_availability.lock_namespace` configuration
to allow operators to specify the exact lock variable namespace.
Copy link
Member

@Juanadelacuesta Juanadelacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow you are fast :)

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to start in high availability mode when using namespace = "*"
3 participants