Fix autoscale when dry-run in set #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemarey
requested review from
jrasell,
Juanadelacuesta and
lgfa29
as code owners
lgfa29
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Thanks @jorgemarey!
I have a vague memory of maybe doing this on purpose to always enforce the min/max values, but thinking about it again it doesn't make sense to bypass the dry-run mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoscaler tries to scale even when dry-run is configured. This happens when the current count is out of the range of the configured min/max. Currently the dry-run check is performed after this checks are executed.
nomad-autoscaler/policyeval/base_worker.go
Line 146 in 0d0ad24
This PR moves the dry-run check to inside the scaleTarget method so every scaling action goes through the check.