Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: add query_window_offset configuration #850

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Feb 10, 2024

The Nomad Autoscaler uses the current time as the end of the query window. This can cause instability, specially for strategies that only take the most recent data point into account, because the latest data may still be processing.

query_window_offset defines a time offset applied to the query window to push it back in time. A short query_window_offset value can help with the unstable readings, and a long value can be used for predictive scaling based on historical data (for example, from 7d ago).

Closes #843.

@lgfa29
Copy link
Contributor Author

lgfa29 commented Feb 10, 2024

Tests fixed in #851

The Nomad Autoscaler uses the current time as the end of the query
window. This can cause instability, specially for strategies that only
take the most recent data point into account, because the latest data
may still be processing.

`query_window_offset` defines a time offset applied to the query window
to push it back in time. A short `query_window_offset` value can help
with the unstable readings, and a long value can be used for predictive
scaling based on historical data (for example, from `7d` ago).
@lgfa29 lgfa29 force-pushed the f-query-window-offset branch from 590894d to e2f2edc Compare February 13, 2024 02:22
@lgfa29
Copy link
Contributor Author

lgfa29 commented Feb 13, 2024

Tests fixed in #851

Rebased to pick-up test fixes

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog APM: Including now in time range causes incorrect scaling actions
2 participants