This repository has been archived by the owner on Dec 2, 2022. It is now read-only.
support for nomad 0.11.1 API #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved script to this dir (gomodules wanted that) updated generator to handle canonical output for corner cases
Volumes, and Scaling
JobRegistrationResponse
tgross
reviewed
May 11, 2020
sdk/src/main/java/com/hashicorp/nomad/javasdk/CSIVolumesApi.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String toString() { | ||
| return NomadJson.serialize(this); |
There was a problem hiding this comment.
This wasn't well-documented in the code but MountOptions are sensitive. We're (with hashicorp/nomad#7923) going to redact them from the HTTP API response so that they're always shown as null here.
There was a problem hiding this comment.
that's fine. thanks.
sdk/src/main/java/com/hashicorp/nomad/javasdk/CSIPluginsApi.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/hashicorp/nomad/javasdk/CSIVolumesApi.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the generator with multiple changes to handle the problematic cases in the API.
Updated generator to use go modules.
Updated the API target to 0.11.1 (the latest 0.11.x release).