cache: respect UserCacheDir
convention
#172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry cache pollutes the user's home directory with a
~/.nomad
directory. Desktop operating systems have platform-specificconventions for placing cache directories (XDG standard on Unix,
~/Library/Caches
on Darwin,%AppData%
on Windows, etc.). Goprovides a
os.UserCacheDir
function that does the right thing forthe platform it's being called on.
We can't exactly unit test this change without messing up the test runner's home directory, but here's what it looks like after building locally on macOS: