Add operations flagset to status command for --name #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
requested review from
DerekStrickland,
jazzyfresh,
jrasell and
lgfa29
as code owners
angrycub
force-pushed
the
b-status-name
branch
from
a0259a9 to
c4f6039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
TestStatusFailstest was supposed to be validating that providing the--nameflag absent a pack name was an error; however, the test currently only looks for a non-successful error code. In this case, the--nameflag was missing from the status command, but since that error also returned exitcode 1 the test was passing anyway.I've updated the command, and there is a big test improvement PR coming that will enable us to check the returned errors from command calls.
Reminders
CHANGELOG.mdentry