[cli] Add flags to change exit codes on plan command #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
requested review from
DerekStrickland,
jazzyfresh,
jrasell and
lgfa29
as code owners
lgfa29
approved these changes
Apr 11, 2022
Comment on lines
+198
to
+217
| f.IntVar(&flag.IntVar{ | ||
| Name: "exit-code-no-changes", | ||
| Target: &c.exitCodeNoChanges, | ||
| Default: 0, | ||
| Usage: `Override exit code returned when the plan shown no changes.`, | ||
| }) | ||
|
|
||
| f.IntVar(&flag.IntVar{ | ||
| Name: "exit-code-makes-changes", | ||
| Target: &c.exitCodeChanges, | ||
| Default: 1, | ||
| Usage: `Override exit code returned when the plan shows changes.`, | ||
| }) | ||
|
|
||
| f.IntVar(&flag.IntVar{ | ||
| Name: "exit-code-error", | ||
| Target: &c.exitCodeError, | ||
| Default: 255, | ||
| Usage: `Override exit code returned when there is an error.`, | ||
| }) |
There was a problem hiding this comment.
One alternative that I thought would be to have k=v flag that can be defined multiple times instead of specific flags:
$ nomad-pack plan -exit-code "error=20" -exit-code "no-changes=2"It seems like it would be easier to add new values, but I don't know if it would actually provide any real benefit.
angrycub
force-pushed
the
f-plan-exit-codes
branch
from
23e1df6 to
44327cf
Compare
angrycub
added
type/enhancement
theme/pack/execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide CLI flags to allow end users to specify the exit codes for the
plancommand.Closes #224
Reminders
CHANGELOG.mdentry