Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nomad OpenAPI #271

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Update Nomad OpenAPI #271

merged 4 commits into from
Jul 19, 2022

Conversation

DerekStrickland
Copy link
Contributor

@DerekStrickland DerekStrickland commented Jul 13, 2022

Update Nomad OpenAPI dependency.

Closes #270

@DerekStrickland DerekStrickland changed the title Update api Update Nomad OpenAPI Jul 13, 2022
@DerekStrickland DerekStrickland removed the request for review from jazzyfresh July 13, 2022 20:46
go.mod Outdated
Comment on lines 18 to 19
github.com/hashicorp/nomad v1.3.0-rc.1
github.com/hashicorp/nomad-openapi v0.0.0-20220623151231-ccfbbe2cdd4a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be the release candidate? Any chance it can be v1.3.2 that was just released?

Copy link
Contributor Author

@DerekStrickland DerekStrickland Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a release candidate. It is just a patch to unblock a user. But that said, it does make sense to update the upstream and then this again (apologies, I'd thought that was done). I'll handle it Monday when I return.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DerekStrickland DerekStrickland merged commit 8f2da81 into main Jul 19, 2022
@DerekStrickland DerekStrickland deleted the update-api branch July 19, 2022 20:40
@robloxrob
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Nomad Pack Nomad API Libraries to 1.3.X+
4 participants