Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack: separate registry list and pack list commands #337

Merged
merged 8 commits into from
Jun 6, 2023

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented May 10, 2023

Description

This PR changes nomad-pack registry list command to display a list of registries, i.e.:

$ nomad-pack registry list
  REGISTRY NAME |  REF   | LOCAL REF |                    REGISTRY URL
----------------+--------+-----------+-----------------------------------------------------
  community     | latest | bd48167   | github.com/hashicorp/nomad-pack-community-registry

and adds a new nomad-pack list command that lists only packs:

$ nomad-pack list
          PACK NAME          | METADATA VERSION |   REGISTRY NAME
-----------------------------+------------------+--------------------
  alertmanager               | 0.0.1            | community@bd48167
  aws_efs_csi                | 0.0.1            | community@bd48167
  boundary                   | 0.0.1            | community@bd48167
  chaotic_ngine              | 0.0.1            | community@bd48167
  csi_openstack_cinder       | 0.0.1            | community@bd48167
  drone                      | 0.0.1            | community@bd48167
  faasd                      | 0.0.1            | community@bd48167
  fabio                      | 0.0.1            | community@bd48167
  grafana                    | 0.1.0            | community@bd48167
  haproxy                    | 0.0.1            | community@bd48167
  hashicups                  | 0.0.1            | community@bd48167
  hello_world                | 0.0.1            | community@bd48167
  influxdb                   | 0.0.1            | community@bd48167
  jaeger                     | 0.0.1            | community@bd48167
  jenkins                    | 0.0.1            | community@bd48167
  kibana                     | 0.0.1            | community@bd48167
  loki                       | 0.0.1            | community@bd48167
  nextcloud                  | 0.0.1            | community@bd48167
  nginx                      | 0.0.1            | community@bd48167
  nomad_autoscaler           | 0.0.1            | community@bd48167
  nomad_ingress_nginx        | 0.0.1            | community@bd48167
  opentelemetry_collector    | 0.0.1            | community@bd48167
  outline                    | 0.0.1            | community@bd48167
  prometheus                 | 0.0.1            | community@bd48167
  prometheus_consul_exporter | 0.0.1            | community@bd48167
  prometheus_node_exporter   | 0.0.1            | community@bd48167
  prometheus_snmp_exporter   | 0.0.1            | community@bd48167
  promtail                   | 0.0.1            | community@bd48167
  rabbitmq                   | 0.0.1            | community@bd48167
  redis                      | 0.0.1            | community@bd48167
  simple_service             | 0.0.1            | community@bd48167
  sonarqube                  | 0.0.1            | community@bd48167
  tempo                      | 0.0.1            | community@bd48167
  tfc_agent                  | 0.1.0            | community@bd48167
  traefik                    | 0.1.0            | community@bd48167
  vector                     | 0.0.1            | community@bd48167
  wordpress                  | 0.0.1            | community@bd48167

Resolves #354.

Reminders

  • Add CHANGELOG.md entry

@pkazmierczak pkazmierczak changed the base branch from main to f-store-local-refs May 10, 2023 14:52
Base automatically changed from f-store-local-refs to main May 17, 2023 13:46
@pkazmierczak pkazmierczak force-pushed the f-pack-list-registry-list branch from e41fc06 to 55265c0 Compare May 22, 2023 08:17
@pkazmierczak pkazmierczak force-pushed the f-pack-list-registry-list branch from 55265c0 to 5046a96 Compare May 31, 2023 16:55
@pkazmierczak pkazmierczak self-assigned this Jun 2, 2023
@pkazmierczak pkazmierczak marked this pull request as ready for review June 2, 2023 07:24
@pkazmierczak pkazmierczak requested review from angrycub and shoenig June 2, 2023 07:24
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak force-pushed the f-pack-list-registry-list branch from a9a285b to 51d1f3c Compare June 6, 2023 06:44
@pkazmierczak pkazmierczak merged commit dc942fd into main Jun 6, 2023
@pkazmierczak pkazmierczak deleted the f-pack-list-registry-list branch June 6, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "registry list" to list registries and add "list" for listing Packs
2 participants