Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dependencies to be pinned to a git ref #447

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

attachmentgenie
Copy link
Contributor

@attachmentgenie attachmentgenie commented Oct 24, 2023

Description

We would prefer our dependencies to be pinned so that rerunning nomad-pack deps vendor would always yield the same result.

Also a small fix for the template, the current proposed source string errors out. This also includes the shallow cloning patch as applied in #444 for registries as a whole

Reminders

  • Add CHANGELOG.md entry

Signed-off-by: Bram Vogelaar <bram@attachmentgenie.com>
Signed-off-by: Bram Vogelaar <bram@attachmentgenie.com>
@attachmentgenie
Copy link
Contributor Author

@pkazmierczak i feel that this PR and #444 are linked, would you please be so kind and review this one too. The code for registry add and deps vendor are starting to look alike however. To the point i would be open to refactoring the code for both to use the same function to achieve thise

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @attachmentgenie, this is my feedback for this PR and for #444: let's do shallow cloning like you suggested. After discussing this with @angrycub we agree that shallow clones are the way to go. There's just no need for extra git info in our caches, and in general we like the direction of migrating away from git-centric registries and caches for pack. So: LGTM!

@pkazmierczak pkazmierczak merged commit d4f4e46 into hashicorp:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants