Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path separators to slash on windows for local packs #578

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

teyyubismayil
Copy link
Contributor

@teyyubismayil teyyubismayil commented Sep 24, 2024

Description
Replace path separators to slash on windows for local packs. It is for fixing issue 577,

Reminders

  • Add CHANGELOG.md entry

Copy link

hashicorp-cla-app bot commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teyyubismayil and thanks for raising this PR.

The linter check is currently failing, if you have a chance to take a look at this that would be great. Otherwise, please let me know, and I'll push a fix.

@jrasell jrasell self-assigned this Oct 16, 2024
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @teyyubismayil!

@jrasell jrasell merged commit 6a3afbd into hashicorp:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants