Skip to content

Commit

Permalink
backport of commit f5d0424
Browse files Browse the repository at this point in the history
  • Loading branch information
shoenig committed Mar 14, 2023
1 parent f477dcf commit 6089be2
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions nomad/structs/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,7 @@ func (t *SidecarTask) Equal(o *SidecarTask) bool {
return false
}

// config compare
// task config, use opaque maps equal
if !helper.OpaqueMapsEqual(t.Config, o.Config) {
return false
}
Expand Down Expand Up @@ -1400,7 +1400,8 @@ func (p *ConsulProxy) Equal(o *ConsulProxy) bool {
return false
}

if !helper.OpaqueMapsEqual(p.Config, o.Config) {
// envoy config, use reflect
if !reflect.DeepEqual(p.Config, o.Config) {
return false
}

Expand Down Expand Up @@ -1495,7 +1496,8 @@ func (u *ConsulUpstream) Equal(o *ConsulUpstream) bool {
return false
case !u.MeshGateway.Equal(o.MeshGateway):
return false
case !helper.OpaqueMapsEqual(u.Config, o.Config):
case !reflect.DeepEqual(u.Config, o.Config):
// envoy config, use reflect
return false
}
return true
Expand Down Expand Up @@ -1781,7 +1783,8 @@ func (p *ConsulGatewayProxy) Equal(o *ConsulGatewayProxy) bool {
return false
}

if !helper.OpaqueMapsEqual(p.Config, o.Config) {
// envoy config, use reflect
if !reflect.DeepEqual(p.Config, o.Config) {
return false
}

Expand Down

0 comments on commit 6089be2

Please sign in to comment.