Pull snapshotting out of loop

hashicorp · Mar 16, 2018 · 8be12ee · 8be12ee
1 parent 3500ed7
commit 8be12ee
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/nomad/job_endpoint.go b/nomad/job_endpoint.go
@@ -674,17 +674,18 @@ func (j *Job) BatchDeregister(args *structs.JobBatchDeregisterRequest, reply *st
 		}
 	}
 
+	// Grab a snapshot
+	snap, err := j.srv.fsm.State().Snapshot()
+	if err != nil {
+		return err
+	}
+
 	// Loop through to create evals
 	for jobNS, options := range args.Jobs {
 		if options == nil {
 			return fmt.Errorf("no deregister options provided for %v", jobNS)
 		}
 
-		// Lookup the job
-		snap, err := j.srv.fsm.State().Snapshot()
-		if err != nil {
-			return err
-		}
 		job, err := snap.JobByID(nil, jobNS.Namespace, jobNS.ID)
 		if err != nil {
 			return err