Skip to content

Commit

Permalink
Fixes an issue where shift+num would not open an eval on the evaluati…
Browse files Browse the repository at this point in the history
…ons index table (#20047)
  • Loading branch information
philrenaud authored Feb 29, 2024
1 parent 8f3f2a8 commit c2fe51b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/20047.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixed an issue where keynav would not trigger evaluation sidebar expand
```
3 changes: 2 additions & 1 deletion ui/app/controllers/evaluations/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ export default class EvaluationsController extends Controller {
e instanceof MouseEvent ||
(e instanceof KeyboardEvent &&
(e.code === 'Enter' || e.code === 'Space')) ||
!e
!e ||
e === 'keynav'
) {
this.statechart.send('LOAD_EVALUATION', { evaluation });
}
Expand Down
2 changes: 1 addition & 1 deletion ui/app/templates/evaluations/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<td data-test-id
{{keyboard-shortcut
enumerated=true
action=(fn this.handleEvaluationClick row.model)
action=(fn this.handleEvaluationClick row.model "keynav")
}}
>
{{row.model.shortId}}
Expand Down

0 comments on commit c2fe51b

Please sign in to comment.