Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil task resources consistently #119

Closed
ryanuber opened this issue Sep 25, 2015 · 2 comments
Closed

Handle nil task resources consistently #119

ryanuber opened this issue Sep 25, 2015 · 2 comments

Comments

@ryanuber
Copy link
Member

We have some spots (maybe even just docker) where we panic if the provided task resources is a typed nil. We should either handle this uniformly before invoking a specific driver, or remove the panic.

Example: https://github.com/hashicorp/nomad/blob/master/client/driver/docker.go#L65-L67

@cbednarski
Copy link
Contributor

I removed this. Closing for now!

schmichael pushed a commit that referenced this issue Jan 30, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants