-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services: zombie service in nomad service provider #14618
Comments
shoenig
changed the title
servicedico: zombie service in nomad service provider
services: zombie service in nomad service provider
Sep 19, 2022
shoenig
added a commit
that referenced
this issue
May 12, 2023
This PR fixes a bug where issuing a restart to a terminal allocation would cause the allocation to run its hooks anyway. This was particularly apparent with group_service_hook who would then register services but then never deregister them - as the allocation would be effectively in a "zombie" state where it is prepped to run tasks but never will. Fixes #17079 Fixes #16238 Fixes #14618
shoenig
added a commit
that referenced
this issue
May 12, 2023
This PR fixes a bug where issuing a restart to a terminal allocation would cause the allocation to run its hooks anyway. This was particularly apparent with group_service_hook who would then register services but then never deregister them - as the allocation would be effectively in a "zombie" state where it is prepped to run tasks but never will. Fixes #17079 Fixes #16238 Fixes #14618
shoenig
added a commit
that referenced
this issue
May 15, 2023
This PR fixes a bug where issuing a restart to a terminal allocation would cause the allocation to run its hooks anyway. This was particularly apparent with group_service_hook who would then register services but then never deregister them - as the allocation would be effectively in a "zombie" state where it is prepped to run tasks but never will. Fixes #17079 Fixes #16238 Fixes #14618
shoenig
added a commit
that referenced
this issue
May 15, 2023
This PR fixes a bug where issuing a restart to a terminal allocation would cause the allocation to run its hooks anyway. This was particularly apparent with group_service_hook who would then register services but then never deregister them - as the allocation would be effectively in a "zombie" state where it is prepped to run tasks but never will. Fixes #17079 Fixes #16238 Fixes #14618
This was referenced May 16, 2023
Going to assign myself this as a likely dupe of #16616. If anyone has additional info on this, please see my comment here: #16616 (comment) first and report in that thread. Closing as duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been playing whack-a-bug getting this job to run, there were client restarts and task failures, etc, and eventually got it working but also noticed in the end there are 2 services registered when there should be only 1.
Not great, but the real problem now is there doesn't seem to be a way to delete the zombie service. Stopping the job does not clean it up, and theservice delete
command requires aservice_id
which I don't(?) have.Edit: Can get the service_id via
nomad service info -verbose <name>
and thus delete with2 services in provider (unexpected!)
but only 1 alloc (with 1 task)
and for sure just the one instance running (expected)
Only the
:21314
should be registered at this pointjob file for reference
The text was updated successfully, but these errors were encountered: