Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw_exec driver doesn't allow space in command field, even inside a path. #1737

Closed
ninoles opened this issue Sep 23, 2016 · 2 comments
Closed

Comments

@ninoles
Copy link
Contributor

ninoles commented Sep 23, 2016

This is related to the change in #842, sorry to find it out so lately.

If you create a job with a space in the command path, this will failed since the check only check for any whitespace. A more thorough check should be done to allow quoting (or the check should be downgrade to a warning, preferably during the submission of the job, not that late!).

Thanks,
Fabien

@ninoles
Copy link
Contributor Author

ninoles commented Sep 23, 2016

I'm trying to figure out what should be the right fix for that, but I feel that the best way is to simply accept commands with space inside the path. Given the fact that the error is reported so lately, the result is almost the same: the executor either report this error (which is misleading if the process actually doesn't have any argument) or fail because the file actually doesn't exist. May be the message in case of error could be modified in this regard, and the validation removed ?

@dadgar dadgar added this to the v0.5.0 milestone Sep 26, 2016
dadgar added a commit that referenced this issue Nov 10, 2016
This PR removes validation that the command string does not contain
spaces. This can cause issues where the path contains a folder that
includes a space ("C:\Program Files\Python35\python.exe").

Fixes #1737
devendram pushed a commit to pubnub/nomad that referenced this issue Nov 14, 2016
This PR removes validation that the command string does not contain
spaces. This can cause issues where the path contains a folder that
includes a space ("C:\Program Files\Python35\python.exe").

Fixes hashicorp#1737
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants