build: upgrade to go1.22 #20066
Merged
build: upgrade to go1.22 #20066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for compatability with go1.22
|
Fixed Also needed to update
|
shoenig
added
backport/1.5.x
This was referenced Mar 6, 2024
shoenig
added a commit
that referenced
this pull request
Mar 6, 2024
(manual cherry-pick of 55b0795) * build: upgrade to go1.22 * add cl * build: use codecgen from go-msgpack v1.1.5+base32 and stringer 0.18.0 for compatability with go1.22 * ci: update golangci-lint to 1.56.2 * build: update hclogvet for go1.22 * build: bump to go1.22.1
shoenig
added a commit
that referenced
this pull request
Mar 6, 2024
(manual cherry-pick of 55b0795) * build: upgrade to go1.22 * add cl * build: use codecgen from go-msgpack v1.1.5+base32 and stringer 0.18.0 for compatability with go1.22 * ci: update golangci-lint to 1.56.2 * build: update hclogvet for go1.22 * build: bump to go1.22.1 Co-authored-by: Seth Hoenig <shoenig@duck.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oof, there's some
go-msgpackproblems withgo1.22It appears
NewEncodingno longer allows duplicate characters in the alphabet you supply.https://go-review.googlesource.com/c/go/+/520335
However go-msgpack (and upstream ugorji) use two underscores in the msgpack alphabet.
https://github.com/hashicorp/go-msgpack/blob/v2.1.1/codec/gen.go#L135