Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of build: upgrade to go1.22 into release/1.7.x #20082

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #20066 to be assessed for backporting due to the inclusion of the label backport/1.7.x.

The below text is copied from the body of the original PR.


oof, there's some go-msgpack problems with go1.22

 ==> Running go generate...
codecgen error: error running 'go run codecgen-main-102.generated.go': exit status 1, console: panic: encoding alphabet includes duplicate symbols

goroutine 1 [running]:
encoding/base64.NewEncoding(...)
	/opt/hostedtoolcache/go/1.22.0/x64/src/encoding/base64/base64.go:82
github.com/hashicorp/go-msgpack/codec.init()
	/home/runner/go/pkg/mod/github.com/hashicorp/go-msgpack@v1.1.5/codec/gen.go:140 +0xce6
exit status 2

It appears NewEncoding no longer allows duplicate characters in the alphabet you supply.
https://go-review.googlesource.com/c/go/+/520335

However go-msgpack (and upstream ugorji) use two underscores in the msgpack alphabet.
https://github.com/hashicorp/go-msgpack/blob/v2.1.1/codec/gen.go#L135


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/upgrade-go-122/possibly-faithful-gopher branch from 123d5de to 21ba12d Compare March 6, 2024 15:54
@shoenig shoenig merged commit a08a86f into release/1.7.x Mar 6, 2024
19 of 20 checks passed
@shoenig shoenig deleted the backport/upgrade-go-122/possibly-faithful-gopher branch March 6, 2024 16:36
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants