Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Notes on consul health checks #21372

Closed
nicoche opened this issue May 20, 2024 · 4 comments · Fixed by #22397
Closed

Allow setting Notes on consul health checks #21372

nicoche opened this issue May 20, 2024 · 4 comments · Fixed by #22397
Assignees

Comments

@nicoche
Copy link
Contributor

nicoche commented May 20, 2024

Hey there!

It seems that it's impossible to set the Notes field of Consul health checks using Nomad's.

Is it expected? If no, can we add it? I'm happy to provide a PR.

@pkazmierczak
Copy link
Contributor

Hi @nicoche, thanks for reporting this. It seems we're missing the Notes field on our side of the API indeed. Feel free to submit a PR and I'll review it. Thanks!

@pkazmierczak pkazmierczak self-assigned this May 21, 2024
@nicoche
Copy link
Contributor Author

nicoche commented May 24, 2024

Hey @pkazmierczak ! I will submit a PR soon, then

@nicoche
Copy link
Contributor Author

nicoche commented May 28, 2024

Here goes @pkazmierczak: #22397. Let me know if I missed some needed changes

Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants