UI: Fix rendering of DAS interstitial components #10094
Conversation
With the Ember update, when the will-destroy action is called to check the element height, its height is already zero. That seems strange but I didn’t look into it any further, as using did-insert to store the element lets us check its height before any other actions when a processing button is pressed.
backspace
added
type/bug
theme/ui
theme/enterprise
Ember Asset Size actionAs of 8e1bc91 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
backspace
force-pushed
the
b-ui/recommendation-interstitial-height
branch
from
99e3ad0
to
8e1bc91
Compare
| this.cardHeight = element.clientHeight; | ||
| cardInserted(element) { | ||
| this.element = element; | ||
| } |
There was a problem hiding this comment.
We do something like this in multiple places. It might be worth looking into something like ember-ref-bucket at some point.
There was a problem hiding this comment.
agreed! This whole thing is more clunky than I’d like 😞
| } | ||
|
|
||
| storeCardHeight() { | ||
| this.cardHeight = this.element.clientHeight; |
There was a problem hiding this comment.
This could technically go boom, but not with how storeCardHeight is currently called.
With the Ember update, when the will-destroy action is called to check the element height, its height is already zero. That seems strange but I didn’t look into it any further, as using did-insert to store the element lets us check its height before any other actions when a processing button is pressed.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
With the Ember update, when the will-destroy action is called
to check the element height, its height is already zero. That
seems strange but I didn’t look into it any further, as
using did-insert to store the element lets us use its height
before any other actions when a processing button is pressed.
Thanks to @lgfa29 for catching this.