CSI: Snapshot volume create should use vol.Secrets

[ggriffiths]

Signed-off-by: Grant Griffiths ggriffiths@purestorage.com

Fixes #10639

[ggriffiths]

tested on my dev cluster

[root@ip-70-0-76-58 ~]# nomad version
Nomad v1.1.3-dev (1eff6fd07e2908b495f97b30a95034e331c1b1b6+CHANGES)
[root@ip-70-0-76-58 ~]# nomad volume snapshot create pxvol2 snap4
Snapshot ID         Volume ID     Size    Create Time           Ready?
800687039846414825  283728768536  10 GiB  1970-01-01T00:00:01Z  true

[tgross]

Thanks @ggriffiths! LGTM!

I think in the future it's worth considering if we want to let the user provide snapshot-specific secrets via the API (or from Vault, see #7978), but this will fix the bug at hand and doesn't close off that path for us.

[tgross]

The fix for this will ship in Nomad 1.1.3. Snapshots are new for 1.1.0, so no backport required.

[ggriffiths]

I think in the future it's worth considering if we want to let the user provide snapshot-specific secrets via the API

Agreed, that would also make sense too.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.