CSI: volume snapshot list plugin option is required #12197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-list-snapshots-plugin-arg
branch
from
559edee
to
f2d0b7e
Compare
tgross
force-pushed
the
csi-list-snapshots-plugin-arg
branch
from
f2d0b7e
to
07b336f
Compare
tgross
commented
Mar 4, 2022
Comment on lines
-37
to
-38
| -plugin: Display only snapshots managed by a particular plugin. By default | ||
| this command will query all plugins for their snapshots. |
There was a problem hiding this comment.
This "by default" behavior never worked and never could work, so I'm just calling this a mulligan for the CSI beta and not a backcompat issue we need to worry about. 😀
shoenig
approved these changes
Mar 4, 2022
Comment on lines
-37
to
-38
| -plugin: Display only snapshots managed by a particular plugin. By default | ||
| this command will query all plugins for their snapshots. |
DerekStrickland
approved these changes
Mar 4, 2022
The RPC for listing volume snapshots requires a plugin ID. Update the `volume snapshot list` command to find the specific plugin from the provided prefix.
tgross
force-pushed
the
csi-list-snapshots-plugin-arg
branch
from
07b336f
to
8bffbcd
Compare
lgfa29
added
backport/1.1.x
This was referenced Apr 19, 2022
lgfa29
pushed a commit
that referenced
this pull request
Apr 19, 2022
The RPC for listing volume snapshots requires a plugin ID. Update the `volume snapshot list` command to find the specific plugin from the provided prefix.
lgfa29
pushed a commit
that referenced
this pull request
Apr 19, 2022
The RPC for listing volume snapshots requires a plugin ID. Update the `volume snapshot list` command to find the specific plugin from the provided prefix.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC for listing volume snapshots requires a plugin ID. Update the
volume snapshot listcommand to find the specific plugin from theprovided prefix.
Pulled out of #12193