Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: enable setting choose parameter #12914

Closed
wants to merge 1 commit into from
Closed

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented May 6, 2022

This is PR 1 of 4 in getting HRW enabled chooseService merged - things are complicated because nomad -depends-on-> consul-template -depends-on-> nomad/api, and nomad{/api} are the same repository 😞

1: changes to nomad/api
2: changes to CT (including nomad/api bump) (hashicorp/consul-template#1579)
3: changes to nomad (including CT bump, so that it includes nomad/api changes) (#12862)
4: bump CT (to point at a tagged version of nomad)

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this parameter within the QueryOptions when is specific to service registrations or is the idea that I can be used more broadly moving forward? I am comparing it to how we do /v1/nodes?resource=true for example.

@shoenig
Copy link
Contributor Author

shoenig commented May 12, 2022

Ahh I see, for a parameter specific to an endpoint we can just use the QueryOptions.Params; I'll do that instead

@shoenig shoenig closed this May 12, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants