Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: detect namespace change in config reload #14298

Merged
merged 3 commits into from
Aug 24, 2022
Merged

vault: detect namespace change in config reload #14298

merged 3 commits into from
Aug 24, 2022

Commits on Aug 24, 2022

  1. vault: detect namespace change in config reload 

    The `namespace` field was not included in the equality check between old and new
Vault configurations, which meant that a Vault config change that only changed
the namespace would not be detected as a change and the clients would not be
reloaded.

Also, the comparison for boolean fields such as `enabled` and
`allow_unauthenticated` was on the pointer and not the value of that pointer,
which results in spurious reloads in real config reload that is easily missed in
typical test scenarios.

Includes a minor refactor of the order of fields for `Copy` and `Merge` to match
the struct fields in hopes it makes it harder to make this mistake in the
future, as well as additional test coverage.
    @tgross
    tgross committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b2c2ab5 View commit details
    Browse the repository at this point in the history

  2. add accessor method for testing

    @tgross
    tgross committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    9692586 View commit details
    Browse the repository at this point in the history

  3. fix TLSSkipVerify comparison too

    @tgross
    tgross committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3f63499 View commit details
    Browse the repository at this point in the history