Backport of consul: do not re-register already registered services into release/1.2.x #14926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14917 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR updates Nomad's Consul service client to do map comparisons
using
maps.Equal
instead ofreflect.DeepEqual
. The bug fix is in howDeepEqual
treats nil slices different from empty slices, when actuallythey should be treated the same.
Also, we need to avoid comparing
TaggedAddress
on agent registrations ifnone are set on the Nomad side - because Consul will helpfully set that field
for us on its side.
And some drive-by cleanup
map[string]struct{}
forset.Set
Fixes #14914