-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add copywrite action to check file headers. #17889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but will it work in the ENT repo without needing special creds? @gulducat might be able to answer that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
this doesn't need backports though, does it?
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I don't know the full extent of what the copywrite
command does, I imagine it should be fine. The contents of the repo itself are pulled by actions/checkout
in the first step, which only needs this contents:read
here.
Beyond that, according to the copyright repo's readme, for some operations
A GITHUB_TOKEN environment variable can be used with a Personal Access Token
I suspect the GITHUB_TOKEN (auto-provided by GHA), if used at all in our case, will mainly be to uniquely identify the caller so our private runners don't get some egress-IP rate-limited or something by GH API.
I'd have said yes but then I actually checked the |
This PR's copywrite CI run: https://github.com/hashicorp/nomad/actions/runs/5521733801/jobs/10070278831?pr=17889
closes #17887