client: prevent watching stale alloc state #18612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
reviewed
Sep 28, 2023
tgross
approved these changes
Sep 29, 2023
schmichael
added
backport/1.4.x
When waiting on a previous alloc we must query against the leader before switching to a stale query with index set. Also check to ensure the response is fresh before using it like #18269
schmichael
force-pushed
the
b-allocwatcher-index
branch
from
9463896 to
c7bab36
Compare
schmichael
commented
Sep 29, 2023
Comment on lines
-2433
to
+2434
| case <-time.After(retry): | ||
| case <-timer.C: |
There was a problem hiding this comment.
Sorry this is an unrelated fix from a linting error I introduced in my previous PR: #18601
schmichael
added a commit
that referenced
this pull request
Sep 29, 2023
When waiting on a previous alloc we must query against the leader before switching to a stale query with index set. Also check to ensure the response is fresh before using it like #18269
schmichael
added a commit
that referenced
this pull request
Sep 29, 2023
When waiting on a previous alloc we must query against the leader before switching to a stale query with index set. Also check to ensure the response is fresh before using it like #18269
schmichael
added a commit
that referenced
this pull request
Sep 29, 2023
When waiting on a previous alloc we must query against the leader before switching to a stale query with index set. Also check to ensure the response is fresh before using it like #18269
|
Backports failed: https://github.com/hashicorp/nomad/actions/runs/6356400700 Manual 1.4.x backport: e531bf1 Manual 1.5.x backport: 376a350 Manual 1.6.x backport: b6f62d5 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When waiting on a previous alloc we must query against the leader before switching to a stale query with index set.
Also check to ensure the response is fresh before using it like #18269