Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix broken test in deploymentwatcher backport #20376

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Apr 12, 2024

The test added in #20348 for the deployment watcher was backported to 1.5.x but is hitting a compilation error because the signature of a state store method was changed.

The test added in #20348 for the deployment watcher was backported to 1.5.x but
is hitting a compilation error because the signature of a state store method was
changed.
Copy link
Member

@Juanadelacuesta Juanadelacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the point :)

@tgross tgross merged commit f046b36 into release/1.5.x Apr 12, 2024
27 of 29 checks passed
@tgross tgross deleted the fixup-tests-broken-by-1.5.x-backport branch April 12, 2024 15:41
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants