[ui] don't assume that an allocation has a task events array when checking if it hasBeenRestarted #20383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
b-ui/fix-alloc-model-has-been-restarted-checking-for-null-events
branch
from
b1ec864 to
2328d32
Compare
philrenaud
added
backport/1.6.x
…ts, which can sometimes be null
philrenaud
force-pushed
the
b-ui/fix-alloc-model-has-been-restarted-checking-for-null-events
branch
from
2328d32 to
4cb7941
Compare
Ember Test Audit comparison
|
lgfa29
approved these changes
Apr 12, 2024
philrenaud
deleted the
b-ui/fix-alloc-model-has-been-restarted-checking-for-null-events
branch
This was referenced Apr 12, 2024
philrenaud
added a commit
that referenced
this pull request
Apr 18, 2024
…ts, which can sometimes be null (#20383)
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the hasBeenRestarted allocation property checks against its task events, which can sometimes be null
This can result on a job-index-page error when calculating the
filteredAllocationsto show (we don't show those allocations as "failed" that have been restarted/rescheduled if other more recent ones exist, up to a job's desired count)(The
?.is a defensive pattern that fails truthiness checks when the object in question doesn't exist, sos.events?.contentwill returnnullinstead of erroring)