Permit Consul Connect Gateways to be used with podman #20611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optiz0r
force-pushed
the
connect_gateway_podman
branch
from
b830206 to
a343708
Compare
optiz0r
force-pushed
the
connect_gateway_podman
branch
from
a343708 to
99042e6
Compare
tgross
added
the
stage/needs-rebase
Enable use of Consul Connect Gateways (ingresss/terminating/mesh) with podman task driver. task driver for Connect-enabled tasks for sidecar services which used podman if any other task in the same task group was using podman or fell back to docker otherwise. That PR did not consider consul connect gateways, which remained hardcoded to using docker task driver always. This change applies the same heuristic also to gateway tasks, enabling use of podman. Limitations: The heuristic only works where the task group containing the gateway also contains a podman task. Therefore it does not work for the ingress example in the docs (https://developer.hashicorp.com/nomad/docs/job-specification/gateway#ingress-gateway) which uses connect native and requires the gateway be in a separate task.
shoenig
removed
the
stage/needs-rebase
|
Thanks @optiz0r! This LGTM. I'm going to rebase with main and add a changelog entry and then get this merged. |
|
@shoenig Thanks. I think I managed to fix the existing broken tests, but I haven't managed to add any tests to validate the new behaviour. |
shoenig
force-pushed
the
connect_gateway_podman
branch
from
99042e6 to
0cb1b76
Compare
shoenig
approved these changes
May 17, 2024
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable use of Consul Connect Gateways (ingresss/terminating/mesh) with podman task driver.
task driver for Connect-enabled tasks for sidecar services which used podman if any other task in the same task group was using podman or fell back to docker otherwise.
That PR did not consider consul connect gateways, which remained hardcoded to using docker task driver always.
This change applies the same heuristic also to gateway tasks, enabling use of podman.
Limitations: The heuristic only works where the task group containing the gateway also contains a podman task. Therefore it does not work for the ingress example in the docs
(https://developer.hashicorp.com/nomad/docs/job-specification/gateway#ingress-gateway) which uses connect native and requires the gateway be in a separate task.
I've updated existing tests to assume the docker driver, but have not yet added any new tests to verify the auto-detection of podman.