Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update runc to 1.1.13 #23331

Merged
merged 1 commit into from
Jun 14, 2024
Merged

deps: update runc to 1.1.13 #23331

merged 1 commit into from
Jun 14, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 14, 2024

Update runc to 1.1.13 to pick up build support for Go 1.22.4+, in order to ensure we've resolved errors cloning processes into Linux namespaces for libcontainer (exec driver) with new versions of Go and older but still supported versions of glibc.

This changeset has two minor quirks:

  • Testing shows that the reported issues is already resolved on main by upgrading to Go 1.22.4 without this dependency bump, at least for glibc 2.31. Upgrading the dependency should make sure there isn't another glibc version where the problem will still appear.

  • This version of runc refers to fields in cilium/ebpf which are not present in more recent versions of that library. So in order to build, we have to downgrade cilium/ebpf. Fortunately, runc is the only consumer of that transitive dependency.

Closes: #20212
Ref: https://hashicorp.atlassian.net/browse/NET-10078

Update `runc` to 1.1.13 to pick up build support for Go 1.22.4+, in order to
ensure we've resolved errors cloning processes into Linux namespaces for
libcontainer (`exec` driver) with new versions of Go and older but still
supported versions of glibc.

This changeset has two minor quirks:

* Testing shows that the reported issues is already resolved on `main` by
  upgrading to Go 1.22.4 without this dependency bump, at least for glibc 2.31.
  Upgrading the dependency should make sure there isn't another glibc version
  where the problem will still appear.

* This version of `runc` refers to fields in `cilium/ebpf` which are not present
  in more recent versions of that library. So in order to build, we have to
  downgrade `cilium/ebpf`. Fortunately, `runc` is the only consumer of that
  transitive dependency.

Closes: #20212
Ref: https://hashicorp.atlassian.net/browse/NET-10078
@tgross tgross force-pushed the deps-runc-1.1.13 branch from 5cc0a84 to 0e52546 Compare June 14, 2024 17:42
@tgross tgross added this to the 1.8.1 milestone Jun 14, 2024
@tgross tgross added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line theme/dependencies Pull requests that update a dependency file labels Jun 14, 2024
@tgross tgross marked this pull request as ready for review June 14, 2024 18:27
@tgross tgross requested review from shoenig, gulducat and jrasell June 14, 2024 18:27
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tgross tgross merged commit d9a10a6 into main Jun 14, 2024
34 checks passed
@tgross tgross deleted the deps-runc-1.1.13 branch June 14, 2024 18:38
@tgross tgross added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent and removed backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent labels Jun 14, 2024
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line theme/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read init-p: connection reset by peer
2 participants