-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise driver-specific addresses #2709
Merged
Merged
Commits on Jun 22, 2017
-
Implement DriverNetwork and Service.AddressMode
Ideally DriverNetwork would be fully populated in Driver.Prestart, but Docker doesn't assign the container's IP until you start the container. However, it's important to setup the port env vars before calling Driver.Start, so Prestart should populate that.
Configuration menu - View commit details
-
Copy full SHA for 3fddb05 - Browse repository at this point
Copy the full SHA 3fddb05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a7df57 - Browse repository at this point
Copy the full SHA 8a7df57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4117c8b - Browse repository at this point
Copy the full SHA 4117c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b6f6e - Browse repository at this point
Copy the full SHA 57b6f6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee5e02f - Browse repository at this point
Copy the full SHA ee5e02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cda2db2 - Browse repository at this point
Copy the full SHA cda2db2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed23d4 - Browse repository at this point
Copy the full SHA 8ed23d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a464ca3 - Browse repository at this point
Copy the full SHA a464ca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6552e1 - Browse repository at this point
Copy the full SHA e6552e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2023946 - Browse repository at this point
Copy the full SHA 2023946View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81b942e - Browse repository at this point
Copy the full SHA 81b942eView commit details -
Configuration menu - View commit details
-
Copy full SHA for deffe5b - Browse repository at this point
Copy the full SHA deffe5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f37be3 - Browse repository at this point
Copy the full SHA 3f37be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5fdf1d - Browse repository at this point
Copy the full SHA b5fdf1dView commit details -
Also make NOMAD_ADDR_* use host ip:port for consistency. NOMAD_PORT_* varies based on port map and the driver IP isn't exposed as an env var as the only place it can be used is in script checks anyway.
Configuration menu - View commit details
-
Copy full SHA for 5d7fba4 - Browse repository at this point
Copy the full SHA 5d7fba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe3bb07 - Browse repository at this point
Copy the full SHA fe3bb07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ef4a42 - Browse repository at this point
Copy the full SHA 9ef4a42View commit details
Commits on Jun 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a70ad9b - Browse repository at this point
Copy the full SHA a70ad9bView commit details -
Remove defunct DRIVER references in docs
Simplifies things greatly!
Configuration menu - View commit details
-
Copy full SHA for cc29d74 - Browse repository at this point
Copy the full SHA cc29d74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c32582 - Browse repository at this point
Copy the full SHA 8c32582View commit details
Commits on Jun 26, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 85860dc - Browse repository at this point
Copy the full SHA 85860dcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.