Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies leader loop fixes from Consul. #3402

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Applies leader loop fixes from Consul. #3402

merged 1 commit into from
Nov 3, 2017

Conversation

slackpad
Copy link
Contributor

@slackpad slackpad commented Oct 17, 2017

There was a deadlock issue we fixed under hashicorp/consul#3230, and then discovered an issue with under hashicorp/consul#3545. This PR ports over those fixes, as well as makes the revoke actions only happen if leadership was established. This brings the Nomad leader loop inline with Consul's.

There was a deadlock issue we fixed under hashicorp/consul#3230,
and then discovered an issue with under hashicorp/consul#3545. This
PR ports over those fixes, as well as makes the revoke actions only happen if leadership was
established. This brings the Nomad leader loop inline with Consul's.
@slackpad
Copy link
Contributor Author

I don't feel super confident in qualifying this change for Nomad, and I've had some trouble running all the unit tests locally (even without this change), but I thought a PR would be the best way to convey the changes Nomad ought to pull in based on the experience we had with Consul. Can y'all take a look at this one?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants