Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in log framer only affecting Windows #3608

Merged
merged 5 commits into from
Dec 8, 2017

Commits on Nov 30, 2017

  1. Configuration menu
    Copy the full SHA
    88cb8bb View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. Fix race in framer and improperly returned err

    Fixes #3342
    
    Two bugs were fixed:
    
    * Closing the StreamFramer's exitCh before setting the error means other
      goroutines blocked on exitCh closing could see the error as nil. This
      was *not* observered.
    * parseFramerError on Windows would fall through and return an
      improperly captured nil err variable. There's no need for
      parseFramerError to be a closure which fixes the confusion.
    schmichael committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    ac3fffc View commit details
    Browse the repository at this point in the history
  2. Add defensive check to safeguard from future #3342s

    I hate adding "this should never happen" checks, but causing a tight
    loop that OOMs Nomad is just too easy in this code otherwise.
    schmichael committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    13a69bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4bacd6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e99a5f3 View commit details
    Browse the repository at this point in the history