Add flags for bootstrap modes to CLI #79
Conversation
| @@ -67,6 +67,10 @@ func (c *Command) readConfig() *Config { | |||
| flags.BoolVar(&cmdConfig.Server.Enabled, "server", false, "") | |||
| flags.BoolVar(&cmdConfig.Client.Enabled, "client", false, "") | |||
|
|
|||
| // Server-only options | |||
| flags.BoolVar(&cmdConfig.Server.Bootstrap, "bootstrap", false, "") | |||
| flags.IntVar(&cmdConfig.Server.BootstrapExpect, "bootstrap-expect", 0, "") | |||
There was a problem hiding this comment.
Should we add a check after this to enforce mutual exclusivity? The docs indicate that I should not use both of these at the same time.
Also curious.. what's the difference between -bootstrap and -dev?
There was a problem hiding this comment.
Ah good point, I think Consul does the same thing. The difference is that dev mode makes a dual client/server and takes lots of shortcuts to bring it up quickly. Bootstrap mode makes a "real" server with a data dir etc.
There was a problem hiding this comment.
Ahh that make sense. The combined client / server in -dev mode is a pretty big distinction. Thanks for clarifying!
ryanuber
force-pushed
the
f-bootstrap
branch
2 times, most recently
from
001a5b2
to
3337705
Compare
|
I think this is done - high-level view of what changed:
|
ryanuber
force-pushed
the
f-bootstrap
branch
from
3337705
to
7f93fbf
Compare
ryanuber
force-pushed
the
f-bootstrap
branch
from
7f93fbf
to
fbbe4a4
Compare
|
Merging this in since I'm fairly certain we don't want to carry the |
Add flags for bootstrap modes to CLI
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.