UI: Add truncation of rendered search results #8571
Conversation
This closes #8549. Thanks to @optiz0r for the bug report. Having the global search attempt to render every returned result is obviously a mistake! I chose to have the full number of matches still render, though I also considered having it display (10+) instead. The choice of truncating at 10 is arbitrary, maybe a higher number would be preferable, I’m open to suggestions.
Ember Asset Size actionAs of 0975f02 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
There was a problem hiding this comment.
Looks good! This is also sneaky since search does filter down the full set of jobs, but with heavy use of common prefixes (easy with periodic or parameterized jobs) it won't filter down much.
As for capping at 10, I think this is fine. If someone needs to look through a result set of more than 10, maybe global search isn't the right tool.
As for showing the full result count, I think this is okay too. It might be nice to say something like "showing 10 of X,XXX" but that's just a cherry on top.
Ember Test Audit comparison
|
|
Thanks for the feedback, I love cherries on top of course haha so I’ve added that in 0975f02 🥳 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This closes #8549. Thanks to @optiz0r for the bug report. Having
the global search attempt to render every returned result is
obviously a mistake!