Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests for Network Selection Step #371

Closed
nywilken opened this issue Apr 20, 2023 · 2 comments
Closed

Add Unit Tests for Network Selection Step #371

nywilken opened this issue Apr 20, 2023 · 2 comments
Labels
bug sync to jira

Comments

@nywilken
Copy link
Contributor

nywilken commented Apr 20, 2023 •
edited
Loading

Overview of the Issue

After releasing v1.2.3 containing a change to the step_network_info.go for subnet selection when using associate_public_ip_address with no subnet_id or vpc_id set users encountered a regression with subnet selection no longer working as expected. To test the regression fix a set of acceptance tests were added with different scenarios for subnet selection. While the test do represent the issues reported it would be better suited to have a suite of unit tests that can validate the expected functionality.

The lack of tests for the complicated code base is considered a bug that we need to fix.

Related Changes
@github-actions
Copy link

This issue has been synced to JIRA for planning.
JIRA ID: HPR-1098

@nywilken nywilken mentioned this issue Apr 20, 2023
Merged
@lbajolet-hashicorp lbajolet-hashicorp mentioned this issue Apr 21, 2023
Merged
@nywilken
Copy link
Contributor Author

Closed in #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug sync to jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nywilken