Support explicit public ip on default vpc #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
force-pushed
the
support_explicit_public_ip_on_default_vpc
branch
3 times, most recently
from
37c8fd6 to
682b403
Compare
nywilken
suggested changes
Apr 18, 2023
There was a problem hiding this comment.
Hey this is off to a good start. It covers the reported cases and passes as expected. I left a few comments about using SSM and sport instances. The tests take a bit of time to run.
I also left some thoughts on refactoring the code a little, as it was immediately clear to me what was happening. Let me know if you have any feedback or questions.
When implementing the AWS upload of public keys when one private key is set in the configuration, we added one check to the Spot tests. However, these do not define a private key, so the public key was never uploaded, and the test would fail.
If a template requests a public IP for the instance being created, and no VPC or subnet is, we get the default VPC ID and a random subnet in this VPC to associate for the instance being created. This fixes a bug where the public IP was requested, but because no subnet was specified, it wasn't associated explicitely.
lbajolet-hashicorp
force-pushed
the
support_explicit_public_ip_on_default_vpc
branch
from
682b403 to
7e6957b
Compare
nywilken
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
LGTM
--- PASS: TestAccBuilder_SpotInstanceWithPublicIPAddressExplicitelySet (421.39s)
--- PASS: TestAccBuilder_SpotInstanceWithPublicIPAddressExplicitelySet/Spot_instance,_with_public_IP_explicitely_set (89.36s)
--- PASS: TestAccBuilder_SpotInstanceWithPublicIPAddressExplicitelySet/Spot_instance,_with_public_IP_explicitely_unset (113.94s)
--- PASS: TestAccBuilder_SpotInstanceWithPublicIPAddressExplicitelySet/Non-Spot_instance,_with_public_IP_explicitely_set (97.49s)
--- PASS: TestAccBuilder_SpotInstanceWithPublicIPAddressExplicitelySet/Non-Spot_instance,_with_public_IP_explicitely_unset (120.60s)
PASS
lbajolet-hashicorp
deleted the
support_explicit_public_ip_on_default_vpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we set a VPC/Subnet during the
StepNetworkInfoso that if theassociate_public_ip_addressattribute is set totruein the configs, it will be taken into account when setupping the network for the instance we are creating.Closes #18