.github: add action to run acceptance tests

[lbajolet-hashicorp]

Since right now we don't have any way to run acceptance tests on the AWS plugin, we add a workflow that can manually be triggered.

[nywilken]

So a few suggestions here. I would expect the acceptance test to run all test, with the default run pattern to be "TestAcc" .

Suggested change

	PACKER_ACC=1 go test \
	-timeout 3h \
	-count 1 \
	-run "${{ github.event.inputs.run_pattern }}" \
	./builder/ebs
	PACKER_ACC=1 go test \
	-timeout 3h \
	-count 1 \
	-run "${{ github.event.inputs.run_pattern }}" \
	./... \
	-v

[lbajolet-hashicorp]

While I tend to agree, the rationale to separate the actions by builder was so packages could be tested in parallel (although I presume we could do this with an option to go test maybe), and so they can have different timeout/token validity periods.
I can change it however, can't hurt to simplify for now and revisit later if the need to split between components arises.

[nywilken]

That's valid. If you take that approach take care to ensure that there are no tests that overlap with each other or that are sharing the same instance names that would cause any potential conflicts by running in parallel.

[lbajolet-hashicorp]

True! If we see conflicts arising here we can always rename the instances in the problematic tests too, but we can take a look before to make sure it does work as intended before enabling other builders.

[nywilken]

Using "*" is an invalid regexp expression for go test

Suggested change

	default: "*"
	default: "TestAcc"

[lbajolet-hashicorp]

Good call, the pattern was borked indeed, I initially shot for .*, but TestAcc does the trick better.

[nywilken]

Do you plan to add a scheduled cron after running your initial tests?

[lbajolet-hashicorp]

Yes, for now while we're iterating on it I figured that would be enough, but later on I will indeed add a schedule, we can discuss how often would be relevant, but I'd go for once a week for starters?

[nywilken]

Whatever you think is best. I like nightly for active plugins.

[lbajolet-hashicorp]

I don't mind nightly, but I fear this may become costly to run those every day, while once a week would strike a reasonable balance between costs and safety. We can augment/reduce the frequency if we think it runs too often/not often enough.

[nywilken]

Are you limiting to EBS just for the initial testing?

You may already know this but for the SSM tests we will need to install the aws cli and the session manager plugin. But calling out because the the aws-actions doesn't install it.

[lbajolet-hashicorp]

Oh good call for the aws cli and plugin, I completely forgot to install them. I'll add this to the workflow

[nywilken]

Just out of my curiosity, the acceptance service account is used to authenticate and it the assumes another role for testing. Is that correct?

[lbajolet-hashicorp]

That's the idea yes!

[nywilken]

LGTM