Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs: don't error on AMI sharing test unset #414

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

Testing for the AMI sharing between accounts requires multiple extra variables to be set so we can interpolate those values in the template we run the test on.

In case it is not set, the current setup makes acceptance tests fail, which can be counter-productive.
To avoid this problem, we don't error when these variables are not set, but instead we skip the test.

Testing for the AMI sharing between accounts requires multiple extra
variables to be set so we can interpolate those values in the template
we run the test on.

In case it is not set, the current setup makes acceptance tests fail,
which can be counter-productive.
To avoid this problem, we don't error when these variables are not set,
but instead we skip the test.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner September 11, 2023 13:09
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit f98e374 into main Sep 15, 2023
12 checks passed
@nywilken nywilken deleted the skip_multiacc_acc_test branch September 15, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants