Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable setting a snapshot description for EBS surrogate #501

Merged

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Aug 12, 2024

Similar to EBS volume, this PR extends the support of setting Snapshot description in EBS surrogate

@gnought gnought requested a review from a team as a code owner August 12, 2024 08:38
Copy link

hashicorp-cla-app bot commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gnought,

Thanks for the PR!
I left a small comment on the default value, I think the empty default is good enough that we don't need to generate one if not provided.

Aside from that nit, LGTM! Pre-approving so it is not a blocker later.

@lbajolet-hashicorp
Copy link
Contributor

Note: I see you haven't signed the CLAs, would you be able to do so? If not we won't be able to accept the contribution for legal reasons, sorry about that.

@gnought
Copy link
Contributor Author

gnought commented Aug 13, 2024

signed CLA and fixes are pushed. Please review. :)

@lbajolet-hashicorp lbajolet-hashicorp force-pushed the feat/ebssurrogate_snapshot_desc branch from 074dc95 to 32f1eac Compare August 13, 2024 13:30
@lbajolet-hashicorp
Copy link
Contributor

Hi @gnought,

I see I misunderstood something in my previous review: the description you added was already the default (which was not changeable in the current state), so we should continue forwarding it, apologies for missing that.
The PR in its previous state was good, no need for the rerolls; given they're separate commits, I'll force-push this branch again without them, and merge as soon as tests go green.

Thanks for the update!

@lbajolet-hashicorp lbajolet-hashicorp merged commit e708ebc into hashicorp:main Aug 13, 2024
23 checks passed
@gnought gnought deleted the feat/ebssurrogate_snapshot_desc branch August 13, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants