-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable setting a snapshot description for EBS surrogate #501
feat: enable setting a snapshot description for EBS surrogate #501
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gnought,
Thanks for the PR!
I left a small comment on the default value, I think the empty default is good enough that we don't need to generate one if not provided.
Aside from that nit, LGTM! Pre-approving so it is not a blocker later.
Note: I see you haven't signed the CLAs, would you be able to do so? If not we won't be able to accept the contribution for legal reasons, sorry about that. |
signed CLA and fixes are pushed. Please review. :) |
074dc95
to
32f1eac
Compare
Hi @gnought, I see I misunderstood something in my previous review: the description you added was already the default (which was not changeable in the current state), so we should continue forwarding it, apologies for missing that. Thanks for the update! |
Similar to EBS volume, this PR extends the support of setting Snapshot description in EBS surrogate