Skip to content

Extra block device support #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

This PR adds support for specifying extra block devices when creating an instance. This is done through one or more extra block_device blocks in the source definition.

Closes #7
Closes #10

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner April 3, 2023 18:04
@nywilken nywilken self-assigned this Apr 3, 2023
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the extra_block_device_support branch 3 times, most recently from 2c6c763 to 322f3f6 Compare April 4, 2023 20:37
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I left a few suggestions around documentation and code readability (in regards to conditionals). Please take a look at let me know what you think.

@lbajolet-hashicorp lbajolet-hashicorp force-pushed the extra_block_device_support branch from 322f3f6 to e5bc839 Compare April 18, 2023 19:05
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for google local-ssd [gogolecompute] Support for more than one disk
2 participants