[Issues 285, 289] Fix regressions for Tags , Pool scoped VM creation #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated proxmox-api-go to version containing pool assignment fix - handled CPU, Memory, Serials changes added to API between versions
mpywell
changed the title
|
@mpywell, |
lbajolet-hashicorp
approved these changes
Oct 28, 2024
|
@maksimsamt we'll try to release a new version of the plugin this week, assuming all the PRs are in a ready state (since we have a bunch open, we'll try to fold as much in as possible/relevant). I can't promise when that'll happen, but hopefully by Friday this fix should be in |
|
@lbajolet-hashicorp, |
|
@lbajolet-hashicorp can you please cut a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions were introduced by
proxmox-api-gowhich didn't allow hyphens or uppercase letters in tags, and VMs were not being created directly in Pools when configured to do so. Bumpedproxmox-api-goversion.Some other API changes had also occurred between versions around CPU, Memory, Cloud-Init, the VM Description field and Serial Devices which have been handled and tested.
Validation also added for the iso_file field to close out #296.
Closes #285
Closes #289
Closes #296