[Issue 196] feature: datasource to find VM in cluster #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
castorsky
force-pushed
the
feature/datasource-template
branch
from
2599b9a to
155f985
Compare
Basic configuration verification copied from builder. Template in directory test-fixtures works.
castorsky
force-pushed
the
feature/datasource-template
branch
from
155f985 to
5740ec7
Compare
mogrogan
requested changes
Dec 9, 2024
Used anonymous functions instead of a bunch of named ones.
Renamed package and corrected documentation accordingly.
|
In the process of renaming the function and editing the documentation, I noticed two edge cases and fixed them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a datasource which was described in #196.
This datasource searches the PVE cluster for some VMs that matches specified filters and returns VM ID for one (and only one) guest. I have chosen such behavior because it will be straightforward for
proxmox-clonebuilder - there will be no need for user to manipulate lists inlocals.I have included some tests and documentation for datasource (but since this is my very first attempt to publish my work for Packer I may have missed something).
This datasource uses undocumented
metafield from Proxmox API responses. (But the Proxmox team recommended using this field to determine guest creation time in the forum messages).Closes #196