Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 289] Keep generated ISOs when unmount is false #299

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Issue 289] Keep generated ISOs when unmount is false #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions builder/proxmox/common/step_upload_iso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ func (s *stepUploadISO) Cleanup(state multistep.StateBag) {
ui := state.Get("ui").(packersdk.Ui)
client := state.Get("proxmoxClient").(uploader)

// If everything finished successfully and we want to keep the ISO mounted, don't cleanup generated ISO
if _, ok := state.GetOk("success"); ok && !s.ISO.Unmount {
return
}

if (len(s.ISO.CDFiles) > 0 || len(s.ISO.CDContent) > 0) && s.ISO.DownloadPathKey != "" {
// Fake a VM reference, DeleteVolume just needs the node to be valid
vmRef := &proxmoxapi.VmRef{}
Expand Down