Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): github.com/hashicorp/packer-plugin-sdk from 0.5.2 to 0.5.4 #218

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Description

Bumps github.com/hashicorp/packer-plugin-sdk from 0.5.2 to 0.5.4.

packer-plugin-vmware on chore(deps)/packer-plugin-sdkgo get -u github.com/hashicorp/packer-plugin-sdk/
go: upgraded go 1.19 => 1.21.0
go: added toolchain go1.22.5
go: upgraded cloud.google.com/go/storage v1.30.1 => v1.35.1
go: upgraded github.com/google/s2a-go v0.1.4 => v0.1.7
go: upgraded github.com/googleapis/enterprise-certificate-proxy v0.2.4 => v0.3.2
go: upgraded github.com/hashicorp/go-getter/gcs/v2 v2.2.1 => v2.2.2
go: upgraded github.com/hashicorp/go-getter/s3/v2 v2.2.1 => v2.2.2
go: upgraded github.com/hashicorp/go-getter/v2 v2.2.1 => v2.2.2
go: upgraded github.com/hashicorp/packer-plugin-sdk v0.5.2 => v0.5.4
go: upgraded github.com/hashicorp/vault/api v1.10.0 => v1.14.0
go: upgraded golang.org/x/oauth2 v0.11.0 => v0.13.0
go: upgraded golang.org/x/sync v0.4.0 => v0.5.0
go: upgraded golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac => v0.3.0
go: upgraded google.golang.org/api v0.128.0 => v0.150.0

packer-plugin-vmware on  chore(deps)/packer-plugin-sdkgo mod tidy
go: downloading github.com/hashicorp/consul/sdk v0.14.1

packer-plugin-vmware on  chore(deps)/packer-plugin-sdkmake generate
2024/07/06 16:44:47 Copying "docs" to ".docs/"
2024/07/06 16:44:47 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore(deps)/packer-plugin-sdkmake build

packer-plugin-vmware on  chore(deps)/packer-plugin-sdkmake test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.403s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.509s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.869s

packer-plugin-vmware on  chore(deps)/packer-plugin-sdkmake dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

packer-plugin-vmware on  chore(deps)/packer-plugin-sdk

@tenthirtyam tenthirtyam added this to the v1.0.12 milestone Jul 6, 2024
@tenthirtyam tenthirtyam requested a review from nywilken July 6, 2024 20:52
@tenthirtyam tenthirtyam self-assigned this Jul 6, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 6, 2024 20:52
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the SDK. This looks goo. Let's drop the toolchain directive from the go.mod file otherwise plugin development will need Go 1.22.5 or greater. The Go tooling will download the version automatically for you but if this was not the intent we can remove it for now. I've removed the toolchain directive from all other plugins for now.

@tenthirtyam
Copy link
Collaborator Author

Roger that! Will make it so.

…o 0.5.4

Bumps [github.com/hashicorp/packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk) from 0.5.2 to 0.5.4.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the chore(deps)/packer-plugin-sdk branch from f59a766 to d908793 Compare July 7, 2024 01:58
@tenthirtyam tenthirtyam requested a review from nywilken July 7, 2024 01:59
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit 869e612 into main Jul 23, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(deps)/packer-plugin-sdk branch July 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants