fix: version checks #262
Merged
fix: version checks #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lbajolet-hashicorp
approved these changes
Nov 18, 2024
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
2 times, most recently
from
d5629c4 to
fc089e5
Compare
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
from
fc089e5 to
5baf300
Compare
There was a problem hiding this comment.
Hey @tenthirtyam,
Overall this looks good to me, thanks for the reroll with go-version! I left a few last comments regarding versions and error handling, I think there's some small improvements we can make there, but besides that, this looks good to me.
Pre-approving to not block later, I'll let you address my last comments and I'll do a final round of review before merging this.
lbajolet-hashicorp
previously approved these changes
Nov 26, 2024
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
2 times, most recently
from
d54fe9e to
7bb2772
Compare
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
2 times, most recently
from
6c68e15 to
ce350b8
Compare
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
from
ce350b8 to
3e756a8
Compare
- Updates the version checks. - Updates log messages based on INFO or WARN context. - Moves constants to the `driver.go` for easier maintenance. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
fix/player-version-checks
branch
from
3e756a8 to
457f39b
Compare
|
@lbajolet-hashicorp - ready to go! Postive Tests: Min of 13.5.0; running 13.6.1. 2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] Checking VMware Fusion version...
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] VMware Fusion: 13.6.1
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] Checking VMware Fusion paths...
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] - VMware Fusion.app found at: /Applications/VMware Fusion.app
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] - vmware-vmx found at: /Applications/VMware Fusion.app/Contents/Library/vmware-vmx
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] - vmrun found at: /Applications/VMware Fusion.app/Contents/Library/vmrun
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 [INFO] - vmware-vdiskmanager found at: /Applications/VMware Fusion.app/Contents/Library/vmware-vdiskmanager
2024/12/03 20:51:37 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64 plugin: 2024/12/03 20:51:37 Using driver *common.FusionDriver, Success: trueNegative Test: Min of 13.7.0 set as const for testing; running 13.6.1. packer build --force -var-file=photon-4.0-R2.pkrvars.hcl .
vmware-iso.vagrant-vmw: output will be in this color.
Build 'vmware-iso.vagrant-vmw' errored after 74 milliseconds 855 microseconds: failed creating driver : driver initialization failed. fix at least one driver to continue:
* [ERROR] Requires VMware Fusion 13.7.0 or later, 13.6.1 installed |
lbajolet-hashicorp
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hashicorp/go-version.INFOorWARNcontext.driver.gofor easier maintenance.Tests
Postive Tests: Min of 13.5.0; running 13.6.1.
Negative Test: Min of 13.7.0 set as const; running 13.6.1.