Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate plugin from the packer-sdc plugin-validate command #22

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Validate plugin from the packer-sdc plugin-validate command #22

merged 3 commits into from
Nov 12, 2021

Conversation

azr
Copy link
Contributor

@azr azr commented Nov 11, 2021

Going forward, the packer-sdc plugin-check command will be the command to check plugins, this updates this and makes sure we are using the correct version for that.

  • Use packer-sdc plugin-check from imported sdk in makefile
  • make sure we have the most recent sdk
  • make goreleaser use that too

@azr azr requested a review from a team as a code owner November 11, 2021 10:46
nywilken
nywilken approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit ecaaf12 into main Nov 12, 2021
@nywilken nywilken deleted the azr/validate-plugin-with-packer-sdk branch November 12, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azr @nywilken